Improve tools #60
Merged
Improve tools #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 83.31% 83.01% -0.31%
==========================================
Files 102 102
Lines 4310 4322 +12
Branches 829 837 +8
==========================================
- Hits 3591 3588 -3
- Misses 339 346 +7
- Partials 380 388 +8 ☔ View full report in Codecov by Sentry. |
Change some assertions to throwing exceptions, which allows to react to invalid ETL files.
They are not currently supported
Mainly to fix some warnings emitted by clang.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor improvements & clean-up for the utility tools.
This is mainly about naming the tools "tools" instead of "apps" and improving the detection and error reporting of invalid/unsupported ETL files.